RDKEMW-17873: HDMI-CEC Polaris HAL Migration by IshvarKR · Pull Request #57 · rdkcentral/hdmicec

IshvarKR · 2026-06-02T12:23:15Z

No description provided.

apatel859

Can you cimpile this code in normal build and vdevice build and see if you face any compilation issue?

github-actions · 2026-06-08T17:29:50Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

Copilot

Pull request overview

This PR introduces a HAL abstraction + factory to switch the CCEC driver between a legacy C HAL backend (vHAL) and an Android Binder/AIDL backend (AidlHAL), and updates the build to produce/link the new backend libraries.

Changes:

Added HDMICecHal interface and HDMICecHalFactory to select AIDL vs legacy backend at runtime.
Implemented vHAL (legacy C driver wrapper) and AidlHAL (binder/AIDL implementation).
Updated DriverImpl to route all HAL operations through the new interface; updated Makefiles to build/link backend shared libraries.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
ccec/src/Makefile.am	Builds `libvHAL.la` + `libAidlHAL.la` and links them into `libRCEC.la`.
ccec/src/Makefile	Builds `libvHAL.so` + `libAidlHAL.so` and links them into `libRCEC.so`; adds binder/AIDL include/link plumbing.
ccec/src/factoryImpl/HDMICecHal.h	New abstract HAL interface used by `DriverImpl`.
ccec/src/factoryImpl/HDMICecHalFactory.h	Declares factory for backend selection.
ccec/src/factoryImpl/HDMICecHalFactory.cpp	Implements backend selection via binder service discovery.
ccec/src/factoryImpl/vHAL.h	Declares legacy backend wrapper.
ccec/src/factoryImpl/vHAL.cpp	Implements legacy backend wrapper via `HdmiCec*` C APIs.
ccec/src/factoryImpl/AidlHAL.h	Declares AIDL/binder backend.
ccec/src/factoryImpl/AidlHAL.cpp	Implements AIDL/binder backend + poll ACK emulation + frame length filtering.
ccec/src/DriverImpl.hpp	Stores `std::unique_ptr<HDMICecHal>` for the selected backend.
ccec/src/DriverImpl.cpp	Uses `HDMICecHal` for open/close/read/write operations and AIDL-specific behaviors.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 11 comments.

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 9 comments.

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 7 comments.

+    class HalFactoryUtility {
+        enum class BackendType {
+            UNKNOWN,
+            LEGACY,
+            AIDL
+        };
+
+        static BackendType mBackendType;
+
+        bool isAidlServiceAvailable(const android::String16 &expectedServiceName)
+        {
+            CCEC_LOG(LOG_INFO, "isAidlServiceAvailable invoked\r\n");


+{
+    CCEC_LOG(LOG_INFO, "HDMICecHalFactory::Create invoked\r\n");
+
+    if (HalFactoryUtility::isAidlServiceAvailable(IHdmiCec::serviceName().c_str())) {


+    const size_t binder_map_size = (version.protocol_version == 7) ? BINDER_MMAP_SIZE_V7 : BINDER_MMAP_SIZE_V8;
+    void* const mapped_mem = mmap(nullptr, binder_map_size, PROT_READ, MAP_PRIVATE, binder_fd, 0);
+    if (mapped_mem == MAP_FAILED) {
+        CCEC_LOG(LOG_ERROR, "[-] Shared address space context instantiation failed\n");


+    CCEC_LOG(LOG_DEBUG, "HDMICecRdkVHAL::getPhysicalAddress handle=%d ret=%d addr=0x%x\r\n",
+             ret, (physicalAddress ? *physicalAddress : 0));


+int HDMICecAidlHAL::getPhysicalAddress(int handle, unsigned int *physicalAddress)
+{
+    if (physicalAddress != nullptr) {
+        *physicalAddress = 0;
+    }
+
+    CCEC_LOG( LOG_DEBUG, "HDMICecAidlHAL::getPhysicalAddress completed\r\n");
+
+    return 0;
+}


+                     factoryImpl/HDMICecHalFactory.cpp \
+                     factoryImpl/HDMICecRdkVHAL.cpp \
+                     factoryImpl/HDMICecAidlHAL.cpp \
+                     factoryImpl/ServiceManagerCheck.cpp

 libRCEC_la_LDFLAGS = -lpthread


Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 7 comments.

+                     factoryImpl/HDMICecHalFactory.cpp \
+                     factoryImpl/HDMICecRdkVHAL.cpp \
+                     factoryImpl/HDMICecAidlHAL.cpp \
+                     factoryImpl/ServiceManagerCheck.cpp


+    CCEC_LOG(LOG_INFO, "[+] Binder protocol version detected: %d\n", version.protocol_version);
+
+    const size_t binder_map_size = (version.protocol_version == 7) ? BINDER_MMAP_SIZE_V7 : BINDER_MMAP_SIZE_V8;
+    void* const mapped_mem = mmap(nullptr, binder_map_size, PROT_READ, MAP_PRIVATE, binder_fd, 0);


+// Macro definitions for internal use
+#define BINDER_VERSION       _IOWR('b', 9, struct binder_version)
+#define BINDER_WRITE_READ_V7 _IOWR('b', 1, struct binder_write_read_v7)
+#define BC_TRANSACTION_V7    _IOW('c', 0, struct binder_transaction_data_v7)


+        bwr.write_size = write_size;
+        bwr.write_consumed = 0;
+        bwr.write_buffer = static_cast<uint32_t>(reinterpret_cast<uintptr_t>(tx.write_payload.data()));
+        bwr.read_size = read_size;
+        bwr.read_consumed = 0;
+        bwr.read_buffer = static_cast<uint32_t>(reinterpret_cast<uintptr_t>(tx.read_payload.data()));


+            /* Probe with a 2-byte directed frame (GiveDevicePowerStatus) */
+            {
+                AutoLock lock_(mAidlMutex);
+                std::vector<uint8_t> probe;
+                probe.reserve(2);
+                probe.push_back(buf ? buf[0] : 0);
+                probe.push_back(0x8F); // GiveDevicePowerStatus
+
+                SendMessageStatus probeStatus = SendMessageStatus::BUSY;
+                android::binder::Status aidlStatus = mAidlController->sendMessage(probe, &probeStatus);
+                if (aidlStatus.isOk() && probeStatus == SendMessageStatus::ACK_STATE_0) {


+    /**
+     * @brief Get the physical address of the device.
+     *
+     * Legacy: calls HdmiCecGetPhysicalAddress().
+     * AIDL:   queries the physical address via binder.
+     *


+std::unique_ptr<IHDMICecHal> HDMICecHalFactory::Create()
+{
+    CCEC_LOG(LOG_INFO, "HDMICecHalFactory::Create invoked\r\n");
+
+    try {
+        if (HalFactoryUtility::isAidlServiceAvailable(android::String16(IHdmiCec::serviceName().c_str()))) {
+            CCEC_LOG(LOG_INFO, "HDMICecHalFactory: Aidl Service is available — using HDMICecAidlHAL\r\n");
+            return std::make_unique<HDMICecAidlHAL>();
+        }


vinodtel · 2026-06-25T05:23:42Z

I have read the CLA Document and I hereby sign the CLA.

yuvaramachandran-gurusamy · 2026-06-29T06:05:37Z

+
+          ln -sf ../../../mocks/hdmicec/hdmi_cec_driver.h stubs/ccec/drivers/hdmi_cec_driver.h
+
+          cat <<'EOF' > stubs/utils/String16.h


Headerfiles should not created from workflows. It should be maintained in stubs folder as original source file. So Can we remove header file creation here. Move it to stubs.

Updated. Please review.

github-advanced-security · 2026-06-29T09:35:17Z

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 11 comments.

+#define BINDER_VERSION       _IOWR('b', 9, struct binder_version)
+#define BINDER_WRITE_READ_V7 _IOWR('b', 1, struct binder_write_read_v7)
+#define BC_TRANSACTION_V7    _IOW('c', 0, struct binder_transaction_data_v7)
+


+    const size_t tx_words = sizeof(txn) / sizeof(uint32_t);
+    tx.write_payload.reserve(1 + tx_words);
+    tx.write_payload.push_back(BC_TRANSACTION_V7);
+
+    tx.write_payload.resize(1 + tx_words);


+    const size_t binder_map_size = (version.protocol_version == 7) ? BINDER_MMAP_SIZE_V7 : BINDER_MMAP_SIZE_V8;
+    void* const mapped_mem = mmap(nullptr, binder_map_size, PROT_READ, MAP_PRIVATE, binder_fd, 0);
+    if (mapped_mem == MAP_FAILED) {
+        CCEC_LOG(LOG_ERROR, "[-] Shared address space context instantiation failed\n");


+int HDMICecAidlHAL::getPhysicalAddress(int handle, unsigned int *physicalAddress)
+{
+    if (physicalAddress != nullptr) {
+        *physicalAddress = 0;
+    }


+void HDMICecAidlHAL::dispatchRx(unsigned char *buf, int len)
+{
+    if (mRxCb == nullptr) {
+        CCEC_LOG(LOG_DEBUG, "HDMICecAidlHAL::dispatchRx callback not registered\r\n");
+        return;
+    }
+
+    // Track initiator LA from inbound frames so 1-byte poll can be emulated
+    // locally on AIDL backends that reject 1-byte sendMessage payloads.
+    if (buf != nullptr && len >= 1) {
+        const uint8_t srcLA = static_cast<uint8_t>((buf[0] >> 4) & 0x0F);
+        if (srcLA <= 0x0E) {
+            AutoLock lock_(mAidlMutex);
+            mSeenLogicalAddresses.insert(srcLA);
+        }
+    }
+    mRxCb(0, mRxCbData, buf, len);
+}


+int HDMICecAidlHAL::setRxCallback(int handle, HdmiCecRxCallback_t cbfunc, void *data)
+{
+    (void)handle;
+
+    mRxCb = cbfunc;
+    mRxCbData = data;
+
+    CCEC_LOG(LOG_DEBUG, "HDMICecAidlHAL::setRxCallback invoked\r\n");
+    return 0;
+}


+int HDMICecAidlHAL::setTxCallback(int handle, HdmiCecTxCallback_t cbfunc, void *data)
+{
+    (void)handle;
+
+    mTxCb = cbfunc;
+    mTxCbData = data;
+
+    CCEC_LOG(LOG_DEBUG, "HDMICecAidlHAL::setTxCallback invoked\r\n");
+    return 0;
+}


+            /* Probe with a 2-byte directed frame (GiveDevicePowerStatus) */
+            {
+                AutoLock lock_(mAidlMutex);
+                std::vector<uint8_t> probe;
+                probe.reserve(2);
+                probe.push_back(buf ? buf[0] : 0);
+                probe.push_back(0x8F); // GiveDevicePowerStatus
+
+                SendMessageStatus probeStatus = SendMessageStatus::BUSY;
+                android::binder::Status aidlStatus = mAidlController->sendMessage(probe, &probeStatus);
+                if (aidlStatus.isOk() && probeStatus == SendMessageStatus::ACK_STATE_0) {
+                    mSeenLogicalAddresses.insert(destination);
+                    CCEC_LOG(LOG_DEBUG,
+                        "HDMICecAidlHAL::emulateAckForPollFrames destination=0x%X ACKed by 2-byte probe. Emulating ack.\r\n",
+                        destination);
+                    return true;
+                }
+
+                CCEC_LOG(LOG_DEBUG,
+                    "HDMICecAidlHAL::emulateAckForPollFrames destination=0x%X probe NACK/failed (aidlOk=%d status=%d).\r\n",
+                    destination,
+                    aidlStatus.isOk() ? 1 : 0,
+                    static_cast<int>(probeStatus));
+            }


      - name: Generate stub headers
-        # Empty headers to mute errors
        run: >
          cd "$GITHUB_WORKSPACE/hdmicec"
          &&
          mkdir -p
          stubs/rdk/iarmbus
          stubs/ccec/drivers/iarmbus
+          stubs/binder
+          stubs/utils
+          stubs/linux/android
+          stubs/com/rdk/hal/hdmicec
          &&


+std::unique_ptr<IHDMICecHal> HDMICecHalFactory::Create()
+{
+    CCEC_LOG(LOG_INFO, "HDMICecHalFactory::Create invoked\r\n");
+
+    try {
+        if (HalFactoryUtility::isAidlServiceAvailable(android::String16(IHdmiCec::serviceName().c_str()))) {
+            CCEC_LOG(LOG_INFO, "HDMICecHalFactory: Aidl Service is available — using HDMICecAidlHAL\r\n");
+            return std::make_unique<HDMICecAidlHAL>();
+        }
+    } catch (...) {
+        CCEC_LOG(LOG_ERROR, "HDMICecHalFactory: Exception thrown while creating AIDL HAL,\r\n");
+    }
+
+    CCEC_LOG(LOG_INFO, "HDMICecHalFactory: Aidl Service is not available — using legacy HDMICecRdkVHAL\r\n");
+    return std::make_unique<HDMICecRdkVHAL>();
+}


Copilot

Pull request overview

Copilot reviewed 31 out of 31 changed files in this pull request and generated 3 comments.

+
+    const size_t tx_words = sizeof(txn) / sizeof(uint32_t);
+    tx.write_payload.reserve(1 + tx_words);
+    tx.write_payload.push_back(BC_TRANSACTION_V7);


+int HDMICecAidlHAL::getPhysicalAddress(int handle, unsigned int *physicalAddress)
+{
+    if (physicalAddress != nullptr) {
+        *physicalAddress = 0;
+    }
+
+    CCEC_LOG( LOG_DEBUG, "HDMICecAidlHAL::getPhysicalAddress completed\r\n");
+
+    return 0;
+}


+std::unique_ptr<IHDMICecHal> HDMICecHalFactory::Create()
+{
+    CCEC_LOG(LOG_INFO, "HDMICecHalFactory::Create invoked\r\n");
+
+    try {
+        if (HalFactoryUtility::isAidlServiceAvailable(android::String16(IHdmiCec::serviceName().c_str()))) {
+            CCEC_LOG(LOG_INFO, "HDMICecHalFactory: Aidl Service is available — using HDMICecAidlHAL\r\n");
+            return std::make_unique<HDMICecAidlHAL>();
+        }


Copilot

Pull request overview

Copilot reviewed 25 out of 25 changed files in this pull request and generated 7 comments.

+static bool execute_binder_ping(const int binder_fd, const int protocol_version) {
+    const BinderTransaction tx = (protocol_version == 7) ? prepare_v7_transaction() : prepare_v8_transaction();
+    uint32_t bytes_consumed = 0;


+    const size_t binder_map_size = (version.protocol_version == 7) ? BINDER_MMAP_SIZE_V7 : BINDER_MMAP_SIZE_V8;
+    void* const mapped_mem = mmap(nullptr, binder_map_size, PROT_READ, MAP_PRIVATE, binder_fd, 0);
+    if (mapped_mem == MAP_FAILED) {
+        CCEC_LOG(LOG_ERROR, "[-] Shared address space context instantiation failed\n");
+        close(binder_fd);
+        return service_manager_alive;
+    }


+        binder_write_read_v7 bwr{};
+        const size_t write_size = tx.write_payload.size() * sizeof(uint32_t);
+        const size_t read_size = tx.read_payload.size() * sizeof(uint32_t);
+        bwr.write_size = write_size;
+        bwr.write_consumed = 0;
+        bwr.write_buffer = static_cast<uint32_t>(reinterpret_cast<uintptr_t>(tx.write_payload.data()));
+        bwr.read_size = read_size;
+        bwr.read_consumed = 0;
+        bwr.read_buffer = static_cast<uint32_t>(reinterpret_cast<uintptr_t>(tx.read_payload.data()));
+


+int HDMICecAidlHAL::getPhysicalAddress(int handle, unsigned int *physicalAddress)
+{
+    if (physicalAddress != nullptr) {
+        *physicalAddress = 0;
+    }
+
+    CCEC_LOG( LOG_DEBUG, "HDMICecAidlHAL::getPhysicalAddress completed\r\n");
+
+    return 0;
+}


+bool HDMICecAidlHAL::emulateAckForPollFrames(const unsigned char *buf, int len)
+{
+    if (len <= 1) {
+        /*
+         * Poll frame (header only): emulate ACK based on seen-LA cache
+         * and 2-byte probe. This keeps HdmiCecSource ping-based discovery
+         * working on AIDL backend.
+         */
+        const uint8_t destination = (buf != NULL) ? (buf[0] & 0x0F) : 0xFF;
+
+        if (destination <= 0x0E) {
+            /* Check seen-LA cache first */
+            {
+                AutoLock lock_(mAidlMutex);
+                if (mSeenLogicalAddresses.count(destination) > 0) {
+                    CCEC_LOG(LOG_DEBUG,
+                        "HDMICecAidlHAL::emulateAckForPollFrames destination=0x%X present in seen-LA set. Emulating ack.\r\n",
+                        destination);
+                    return true;
+                }
+            }
+
+            /* Probe with a 2-byte directed frame (GiveDevicePowerStatus) */
+            {
+                AutoLock lock_(mAidlMutex);
+                std::vector<uint8_t> probe;
+                probe.reserve(2);
+                probe.push_back(buf ? buf[0] : 0);
+                probe.push_back(0x8F); // GiveDevicePowerStatus
+
+                SendMessageStatus probeStatus = SendMessageStatus::BUSY;
+                android::binder::Status aidlStatus = mAidlController->sendMessage(probe, &probeStatus);
+                if (aidlStatus.isOk() && probeStatus == SendMessageStatus::ACK_STATE_0) {
+                    mSeenLogicalAddresses.insert(destination);
+                    CCEC_LOG(LOG_DEBUG,
+                        "HDMICecAidlHAL::emulateAckForPollFrames destination=0x%X ACKed by 2-byte probe. Emulating ack.\r\n",
+                        destination);
+                    return true;
+                }
+
+                CCEC_LOG(LOG_DEBUG,
+                    "HDMICecAidlHAL::emulateAckForPollFrames destination=0x%X probe NACK/failed (aidlOk=%d status=%d).\r\n",
+                    destination,
+                    aidlStatus.isOk() ? 1 : 0,
+                    static_cast<int>(probeStatus));
+            }
+        }
+
+        CCEC_LOG(LOG_DEBUG,
+            "HDMICecAidlHAL::emulateAckForPollFrames destination=0x%X not present. Returning no-ack.\r\n",
+            (buf != NULL) ? (buf[0] & 0x0F) : 0xFF);
+        throw CECNoAckException();
+    }
+
+    if (static_cast<size_t>(len) > kAidlMaxCecFrameSize) {
+        CCEC_LOG(LOG_EXP,
+            "HDMICecAidlHAL::emulateAckForPollFrames blocking unsupported CEC frame length=%zu on AIDL backend (valid range: 2..16).\r\n",
+            static_cast<size_t>(len));
+        throw IOException();
+    }
+
+    return false;
+}


+#include <cstdint>
+#include <cstdlib>


+            CCEC_LOG(LOG_INFO, "isAidlServiceAvailable invoked\r\n");
+
+            if (mBackendType == BackendType::AIDL) {
+                return true;
+            } else if (mBackendType == BackendType::LEGACY) {
+                return false;
+            }


Copilot

Pull request overview

Copilot reviewed 25 out of 25 changed files in this pull request and generated 5 comments.

+#define BINDER_WRITE_READ _IOWR('b', 1, struct binder_write_read)
+#define BC_TRANSACTION 0x0
+#define TF_ACCEPT_FDS 0x10
+#define BR_REPLY 0x1
+#define BR_DEAD_REPLY 0x2
+#define BR_FAILED_REPLY 0x3
+#define BR_TRANSACTION_COMPLETE 0x4
+#define BR_NOOP 0x5
+#define BR_OK 0x6


+# Calculate AIDL include path relative to workspace
+AIDL_GEN_DIR := $(shell cd ../../.. && pwd)/aidl/rdk-halif-aidl/gen/hdmicec/current
+AIDL_H_DIR := $(AIDL_GEN_DIR)/h
+BINDER_IDL_DIR := $(shell cd ../../.. && pwd)/aidl/rdk-halif-aidl/build-tools/linux_binder_idl
+BINDER_INCLUDE := $(BINDER_IDL_DIR)/android/native/libs/binder/include


+// Return the standard logical-address candidates for a given device type.
+// Used only as a fallback when AIDL reports no allocated addresses yet.
+std::vector<int32_t> preferredLogicalAddressesForDeviceType(int devType)
+{


+int HDMICecAidlHAL::getPhysicalAddress(int handle, unsigned int *physicalAddress)
+{
+    if (physicalAddress != nullptr) {
+        *physicalAddress = 0;
+    }
+
+    CCEC_LOG( LOG_DEBUG, "HDMICecAidlHAL::getPhysicalAddress completed\r\n");
+
+    return 0;
+}


+private:
+    const size_t kAidlMinCecFrameSize = 2;
+    const size_t kAidlMaxCecFrameSize = 16;
+    android::sp<com::rdk::hal::hdmicec::IHdmiCec> getAidlService();


vinodtel requested review from Kishoredarmaradje, Ranjeetha07, Sid2001-maker, anand-ky, apatel859 and vinodtel June 2, 2026 12:51

apatel859 reviewed Jun 2, 2026

View reviewed changes

Comment thread ccec/src/factoryImpl/HDMICecHalFactory.h Outdated

apatel859 reviewed Jun 2, 2026

View reviewed changes

Comment thread ccec/src/factoryImpl/HDMICecHalFactory.cpp Outdated

apatel859 requested changes Jun 2, 2026

View reviewed changes

Sid2001-maker force-pushed the feature/factoryImpl branch 2 times, most recently from 876022c to 1c009ec Compare June 3, 2026 09:34

IshvarKR force-pushed the feature/factoryImpl branch from 02757ea to ba51587 Compare June 9, 2026 10:51

vinodtel marked this pull request as ready for review June 9, 2026 16:55

vinodtel requested a review from a team as a code owner June 9, 2026 16:55

Copilot AI review requested due to automatic review settings June 9, 2026 16:55

Copilot started reviewing on behalf of vinodtel June 9, 2026 16:55 View session

vinodtel changed the title ~~Feature/factory impl~~ VDevice : HDMI-CEC Middleware component Jun 9, 2026

Copilot AI reviewed Jun 9, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings June 11, 2026 09:34

Copilot started reviewing on behalf of vinodtel June 11, 2026 09:34 View session

Copilot AI reviewed Jun 11, 2026

View reviewed changes

Sid2001-maker force-pushed the feature/factoryImpl branch from 174c2b5 to 1c06faf Compare June 11, 2026 10:17

Copilot AI review requested due to automatic review settings June 11, 2026 11:13

Copilot started reviewing on behalf of Sid2001-maker June 11, 2026 11:13 View session

Copilot AI reviewed Jun 11, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings June 15, 2026 10:23

Copilot started reviewing on behalf of vinodtel June 15, 2026 10:23 View session

Copilot AI reviewed Jun 15, 2026

View reviewed changes

Sid2001-maker force-pushed the feature/factoryImpl branch from 32ad93b to 50d97a2 Compare June 15, 2026 10:51

Fixed review comments.

2cebd5d

Copilot AI review requested due to automatic review settings June 23, 2026 08:19

Copilot started reviewing on behalf of vinodtel June 23, 2026 08:19 View session

Copilot AI reviewed Jun 23, 2026

View reviewed changes

vinodtel added 2 commits June 23, 2026 15:11

Added exception handling around AIDL HAL creation.

8f01cb6

Fixed build issue

e36b490

Copilot AI review requested due to automatic review settings June 23, 2026 11:30

Copilot started reviewing on behalf of vinodtel June 23, 2026 11:30 View session

Copilot AI reviewed Jun 23, 2026

View reviewed changes

anand-ky changed the title ~~VDevice : HDMI-CEC Middleware component~~ RDKEMW-17873: HDMI-CEC Polaris HAL Migration Jun 24, 2026

vinodtel changed the base branch from develop to support/AIDL June 26, 2026 16:39

yuvaramachandran-gurusamy requested changes Jun 29, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings June 29, 2026 09:36

Copilot started reviewing on behalf of IshvarKR June 29, 2026 09:37 View session

Copilot AI reviewed Jun 29, 2026

View reviewed changes

IshvarKR force-pushed the feature/factoryImpl branch from 248be82 to 5e1ed8e Compare June 29, 2026 09:46

Copilot AI review requested due to automatic review settings June 29, 2026 10:28

IshvarKR force-pushed the feature/factoryImpl branch from 5e1ed8e to 3dfa44b Compare June 29, 2026 10:28

Copilot started reviewing on behalf of IshvarKR June 29, 2026 10:29 View session

Copilot AI reviewed Jun 29, 2026

View reviewed changes

IshvarKR force-pushed the feature/factoryImpl branch from 3dfa44b to 4a9145c Compare June 29, 2026 11:07

Copilot AI review requested due to automatic review settings June 29, 2026 11:16

Copilot started reviewing on behalf of IshvarKR June 29, 2026 11:17 View session

Update for L1-tests.yml

3097ab2

IshvarKR force-pushed the feature/factoryImpl branch from 76022a7 to 3097ab2 Compare June 29, 2026 11:21

Copilot AI reviewed Jun 29, 2026

View reviewed changes

anand-ky approved these changes Jun 29, 2026

View reviewed changes

		CCEC_LOG(LOG_DEBUG, "HDMICecRdkVHAL::getPhysicalAddress handle=%d ret=%d addr=0x%x\r\n",
		ret, (physicalAddress ? *physicalAddress : 0));


		ln -sf ../../../mocks/hdmicec/hdmi_cec_driver.h stubs/ccec/drivers/hdmi_cec_driver.h

		cat <<'EOF' > stubs/utils/String16.h

		#include <cstdint>
		#include <cstdlib>

Uh oh!

Conversation

IshvarKR commented Jun 2, 2026

Uh oh!

Uh oh!

Uh oh!

apatel859 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

vinodtel commented Jun 25, 2026

Uh oh!

yuvaramachandran-gurusamy Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

IshvarKR Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 8, 2026 •

edited

Loading